Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrade latest #22

Merged
merged 2 commits into from
Sep 10, 2023
Merged

chore(deps): upgrade latest #22

merged 2 commits into from
Sep 10, 2023

Conversation

TheAlmightyCrumb
Copy link
Contributor

No description provided.

@TheAlmightyCrumb
Copy link
Contributor Author

TheAlmightyCrumb commented Sep 6, 2023 •
edited
Loading

@Ari-Kishon
CI fails when it runs on Node 20 due to Node 20 issues causing TypeError: can't redefine non-configurable property "x".
Found a discussion opened just today about this: angular-cli | Issues | Build fails with Cannot redefine property: File using Node 20.6.0
The problem is that Node 20 breaks Babel which affects the build. babel | Issues| [Bug]: @babel/core does not work in node v20.6

@TheAlmightyCrumb TheAlmightyCrumb mentioned this pull request Sep 6, 2023
Merged
@TheAlmightyCrumb TheAlmightyCrumb requested review from shakederin and removed request for Ari-Kishon September 10, 2023 09:15
@TheAlmightyCrumb TheAlmightyCrumb merged commit ad0c516 into main Sep 10, 2023
8 checks passed
@TheAlmightyCrumb TheAlmightyCrumb deleted the sagivd/maintenance-2023-09-06 branch September 10, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakederin shakederin shakederin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@TheAlmightyCrumb @shakederin