Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make example not blow up because of onKey cleanup #40

Closed
codymikol opened this issue Mar 16, 2019 · 1 comment
Closed

Make example not blow up because of onKey cleanup #40

codymikol opened this issue Mar 16, 2019 · 1 comment

Comments

@codymikol
Copy link
Owner

We currently experience #38 and it breaks our example. We should have a better way to display that entities can destroy themselves and just have the OnKeys alter colors. This way we can release 0.0.4 and chalk that up to a known issue until 0.0.6 🐔
@codymikol
Copy link
Owner Author

This will also give us the ability to make the emitted "Spinnys" to clean up after themselves rather than multiply infinitely.

codymikol added a commit that referenced this issue Mar 16, 2019
@codymikol
fix(example): keep example from being 100% busted
b6c191e 
stops onKey from destroying entities as this is a known issue

Fixes #40
@codymikol codymikol mentioned this issue Mar 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codymikol