Skip to content

Commit

Permalink
fix(controller): remove breaking change to optimization (#588)
Browse files Browse the repository at this point in the history
we should not dictate this behavior, just warning
users that this may lead to unexpected behavior
should suffice.

Fixes #587

Co-authored-by: Cody Mikol <cody.mikol@boltstech.com>
  • Loading branch information
codymikol and Cody Mikol committed Feb 13, 2024
1 parent a8d3b1e commit 58c75b3
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions lib/karma-webpack/controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,8 @@ defaulting ${newOptions.output.filename} to [name].js.`.trim()

if (newOptions.optimization) {
console.warn(
'karma-webpack does not support custom optimization configurations for webpack, the optimizations passed will be ignored.'
'karma-webpack may behave unexpectedly when using customized optimizations.'
);
delete newOptions.optimization;
}

this.webpackOptions = merge(this.webpackOptions, newOptions);
Expand Down

0 comments on commit 58c75b3

Please sign in to comment.