Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): Reworks babel build #163

Merged
merged 3 commits into from
Aug 7, 2016
Merged

chore(build): Reworks babel build #163

merged 3 commits into from
Aug 7, 2016

Conversation

joshwiens
Copy link
Contributor

@joshwiens joshwiens commented Aug 6, 2016

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact:
  • Migration path for existing applications:
  • Github Issue(s) this is regarding:

Other information:

  • Add module export in project root
  • Remove npmignore in favor of files array in package.json
  • Adds Travis matrix build Node v4-v6 && Webpack ^1.1.x / ^2.1.0-beta
  • Adds minimal Gulp v4 build
    • clean
    • lint ( ESLint ./src )
    • build ( Babel transpile to ./lib )
    • watch ( Incremental watch & rebuild )
    • default ( Cleans, lints & builds )

* Add module export in project root
* Remove npmignore in favor of files array in package.json
* Adds minimal Gulp v4 build
  - clean
  - lint ( ESLint ./src )
  - build ( Babel transpile to ./lib )
  - watch ( Standard watch & rebuild )
  - default ( Cleans, lints & builds )
@MikaAK
Copy link
Contributor

MikaAK commented Aug 6, 2016

The only thing I would say is babel options should come from .babelrc so they shouldn't be specified

Removes preset from gulp task and uses .babelrc
* add travis-ci matrix covering supported os and webpack versions
* removes webpack 2 beta as a devDep ( we support both majors )
* fixes peerDep for webpack 1.x ( 1.4.0 doesn't exist )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants