fix: disable webpack rebuilds on karma --single-run
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattlewis92
requested review from
alexander-akait,
michael-ciniawsky and
joshwiens
|
There aren't any actual tests in this repo beyond the basic integration one. The next weekend I have free I can sit down and write some in a follow up PR 😄 |
alexander-akait
approved these changes
Aug 10, 2017
joshwiens
force-pushed
the
mattlewis92-disable-watch-on-single-run
branch
from
d867585
to
7f0c33c
Compare
joshwiens
approved these changes
Oct 5, 2017
michael-ciniawsky
approved these changes
Oct 5, 2017
michael-ciniawsky
added
pr_action: Merge ready
status: Approved
and removed
pr_action: Review
severity: 3 (broken)
status: Pending
labels
michael-ciniawsky
changed the title
webpack rebuilds on karma --single-run
|
merge? travis red. Almost 1 month after approved. |
mattlewis92
force-pushed
the
mattlewis92-disable-watch-on-single-run
branch
from
527cfdc
to
a8cff06
Compare
mattlewis92
force-pushed
the
mattlewis92-disable-watch-on-single-run
branch
from
a8cff06
to
2074f60
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
When running a long test suite as a single run, if you make changes to any of the files during the run, webpack will start recompiling
What is the new behavior?
Webpack is only run in watch mode when running karma is not running with the
--single-runflagDoes this PR introduce a breaking change?
If this PR contains a breaking change, please describe the following...
N/A
Other information: