Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badge: Support max value for content #18

Closed
4 tasks
codypearce opened this issue Apr 19, 2019 · 0 comments · Fixed by #241
Closed
4 tasks

Badge: Support max value for content #18

codypearce opened this issue Apr 19, 2019 · 0 comments · Fixed by #241
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v0.2.3

Comments

@codypearce
Copy link
Owner

Describe your feature request
Add prop to for forcing max value on a badge. Show + and the max value if value exceeds this.

Context
Material UI implements this as shown

image

Things that need to be done

  • Add prop for max value
  • Update prop table
  • Add demo section to docs for max value
  • Add storybook story for max value
@codypearce codypearce added enhancement New feature or request good first issue Good for newcomers labels Apr 19, 2019
@codypearce codypearce modified the milestone: v0.0.7 Apr 27, 2019
@codypearce codypearce added this to the v0.1.11 milestone Jul 7, 2019
@codypearce codypearce modified the milestones: v0.1.14, v0.2.0, v0.2.3 Jul 29, 2019
@alburdette619 alburdette619 mentioned this issue Aug 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.2.3
Development

Successfully merging a pull request may close this issue.

18:Badge Max Value alburdette619/material-bread
1 participant
@codypearce