Use slice::iter instead of into_iter to avoid future breakage
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`an_array.into_iter()` currently just works because of the autoref feature, which then calls `<[T] as IntoIterator>::into_iter`. But in the future, arrays will implement `IntoIterator`, too. In order to avoid problems in the future, the call is replaced by `iter()` which is shorter and more explicit.
|
The Travis CI build reports a failure on nightly, but it seems to be a timeout? I built on nightly locally and it seems to compile fine. |
|
bors r+ |
|
This PR was included in a batch with a merge conflict, it will be automatically retried |
1 similar comment
|
This PR was included in a batch with a merge conflict, it will be automatically retried |
bors bot
added a commit
that referenced
this pull request
Dec 23, 2019
84: Use `slice::iter` instead of `into_iter` to avoid future breakage r=jmesmon a=starfys Use `slice::iter` instead of `into_iter` to avoid future breakage `an_array.into_iter()` currently just works because of the autoref feature, which then calls `<[T] as IntoIterator>::into_iter`. But in the future, arrays will implement `IntoIterator`, too. In order to avoid problems in the future, the call is replaced by `iter()` which is shorter and more explicit. A crater run showed that your crate is affected by a potential future change. See rust-lang/rust#65819 for more information. Co-authored-by: Steven Sheffey <stevensheffey4@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
slice::iterinstead ofinto_iterto avoid future breakagean_array.into_iter()currently just works because of the autoreffeature, which then calls
<[T] as IntoIterator>::into_iter. Butin the future, arrays will implement
IntoIterator, too. In orderto avoid problems in the future, the call is replaced by
iter()which is shorter and more explicit.
A crater run showed that your crate is affected by a potential future
change. See rust-lang/rust#65819 for more information.