Fix some issues with DStatusBarCore::DrawString #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here for details.
This fixes two issues with the current scaling implementation of
DStatusBarCore::DrawString:No idea how I didn't notice issue no. 1 back then, sorry about that.
Note that font offsets don't actually seem to work at this time, and this is not related to scaling at all. I can see in the debugger that the X-coordinates are being calculated correctly for glyphs that have offsets, but they always get drawn as if they didn't have one regardless - not sure if a bug or a missing feature.