Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lens flare, now without that unneeded code #244

Closed
wants to merge 12 commits into from

Conversation

Projects
None yet
6 participants
@usernameak
Copy link
Contributor

usernameak commented Feb 8, 2017

No description provided.

@nashmuhandes

This comment has been minimized.

Copy link
Contributor

nashmuhandes commented Feb 8, 2017

Wow, this came out of nowhere! Any images?

Also, I am particularly interested in learning more about what conditions would draw the lens flares. And can modders specifically assign different lens flare textures to different light sources?

Regarding customizable per-actor lens flares, IMO it should be definable inside GLDEFS, in similar fashion to how one would assign brightmaps or dynamic lights to actors. It should take some parameters: the texture to use, the 3D offset of the lens flare, the distance before it fades out. And maybe some other parameters too, like how intense the brightness of the lens flare is (the user CVar would just be multiplier then)

Also, is it possible to create an infinitely-distanced lens flare for eg the sun? I made lens flares using ACS and HudMessage (uggglllyyyy hack) and I was hoping shaders would allow me to get rid of my ACS! (Demo video here : https://www.youtube.com/watch?v=E-1wW0pAp5Y )

(everything in that video is faked using ACS and HudMessage... no shaders. I don't know how to write shaders)

@usernameak

This comment has been minimized.

Copy link
Contributor Author

usernameak commented Feb 8, 2017

@coelckers @nashmuhandes Demo video here : https://youtu.be/TrlogN1Y1uo . That shitty space suit effect can be fixed (yeah, i haven't fixed that yet!) by changing two lines of code. The lens flares are fully rendered by the shader which processes image from screen and adds flares to the light parts.

@coelckers

This comment has been minimized.

Copy link
Owner

coelckers commented Feb 9, 2017

I honestly don't know what to make of this. While it's certainly interesting from a technical point of view, the entire effect feels far too intrusive even on the lowest settings,

@alexey-lysiuk

This comment has been minimized.

Copy link
Collaborator

alexey-lysiuk commented Feb 9, 2017

Exactly. Lens flare is cool as a temporary effect used in suitable places by level/mod author. Although as a permanent post-processing one it's pretty annoying IMHO.
And it could be customized by content creator for particular scenario but not by end users.
I'm curious is there anyone who wants to play with it enabled? If so, disregard my comment and merge it (as the single commit preferably).

@MajorCooke

This comment has been minimized.

Copy link
Contributor

MajorCooke commented Feb 9, 2017

And if merged, it should be more professionally written too.

@coelckers

This comment has been minimized.

Copy link
Owner

coelckers commented Feb 9, 2017

In its current state I see no point to merge it. The effect, even with all sliders at the left is too strong - and to the right it's utterly overblown. I started a thread at the forum to get some more feedback but I strongly tend towards closing the PR.

@nashmuhandes

This comment has been minimized.

Copy link
Contributor

nashmuhandes commented Feb 9, 2017

@usernameak I've left some feedback on the forum too, hope you can check it out when you have time, thanks

@coelckers coelckers closed this Mar 12, 2017

@coelckers

This comment has been minimized.

Copy link
Owner

coelckers commented Mar 12, 2017

The overwhelming consensus was not to use this feature in its current state.

@StrikerMan780

This comment has been minimized.

Copy link
Contributor

StrikerMan780 commented Jun 26, 2017

I think you'd be better off making proper flares using the unused "flare" property for dynamic lights in GLDEFS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.