New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for monospacing alignment modes to HUDFont / BaseStatusBar.DrawString #810
Added support for monospacing alignment modes to HUDFont / BaseStatusBar.DrawString #810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather give the underlying type like int
to EMonospacing
enumeration, and replace #include "v_video.h"
with just a declaration.
Sorry, I'm not particularly familiar with these C++ quirks, so I'm not quite sure what kind of declaration you're talking about... I think you are allowed to push changes to my PR branch, so I'd be happy if you could fix it for me. |
The problem is that the size of EMonospacing is not well defined. Such types shouldn't be used in a script export because they can cause undefined behavior.. So either make the member variable an int or make the enum an int by declaring it as enum EMonospacing : int |
OK, I've added an underlying type declaration to |
With |
OK, done. |
Now I would say "squash everything to one commit", but it's better to wait for Graf's final word on this topic. |
Thanks. Now I can finally get rid of that lousy hack in my mod code... |
…Bar.DrawString (ZDoom#810) * - Added support for monospacing alignment modes to HUDFont / BaseStatusBar.DrawString * - added underlying type declaration for EMonospacing * - replaced "#include v_video.h" with a declaration of EMonospacing
…Bar.DrawString (ZDoom#810) * - Added support for monospacing alignment modes to HUDFont / BaseStatusBar.DrawString * - added underlying type declaration for EMonospacing * - replaced "#include v_video.h" with a declaration of EMonospacing
This PR adds support for monospacing alignment modes to HUDFont (and therefore to BaseStatusBar.DrawString). See here for details. Updated test WAD / screenshot can be found in the thread.