Fixes for Door_AnimatedClose #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
XxMiltenXx
commented
May 11, 2019
XxMiltenXx
commented
- Fixing that Door_AnimatedClose would be activated on an already closed door (playing the sound and the 1st frame of the animation)
- There was no check if the Door is already Animated when a tag was used with Door_AnimatedClose
- Fixing that Door_AnimatedClose would be activated on an already closed door (playing the sound and the 1st frame of the animation) - There was no check if the Door is already Animated when a tag was used with Door_AnimatedClose
alexey-lysiuk
requested changes
May 12, 2019
|
Since the Github interface allows squash merges there's really no need to do these manually. |
drfrag666
pushed a commit
to drfrag666/gzdoom
that referenced
this pull request
May 12, 2019
* Fixes for Door_AnimatedClose - Fixing that Door_AnimatedClose would be activated on an already closed door (playing the sound and the 1st frame of the animation) - There was no check if the Door is already Animated when a tag was used with Door_AnimatedClose * Removed doubled "door->StartClosing();".
drfrag666
pushed a commit
to drfrag666/gzdoom
that referenced
this pull request
May 12, 2019
* Fixes for Door_AnimatedClose - Fixing that Door_AnimatedClose would be activated on an already closed door (playing the sound and the 1st frame of the animation) - There was no check if the Door is already Animated when a tag was used with Door_AnimatedClose * Removed doubled "door->StartClosing();".
madame-rachelle
pushed a commit
that referenced
this pull request
May 14, 2019
* Fixes for Door_AnimatedClose - Fixing that Door_AnimatedClose would be activated on an already closed door (playing the sound and the 1st frame of the animation) - There was no check if the Door is already Animated when a tag was used with Door_AnimatedClose * Removed doubled "door->StartClosing();".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.