PortMidi: Clean up "reset all controllers"

coelckers · Jun 13, 2023 · a13e885 · a13e885
1 parent 66ec4e8
commit a13e885
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/prboom2/src/MUSIC/portmidiplayer.c b/prboom2/src/MUSIC/portmidiplayer.c
@@ -638,7 +638,6 @@ static void pm_render (void *vdest, unsigned bufflen)
               {
                 writeevent (when, 0xB0, i, 0x7B, 0x00); // all notes off
                 writeevent (when, 0xB0, i, 0x79, 0x00); // reset all controllers
-                write_volume (when, i, channel_volume[i]); // reapply volume
               }
               continue;
             }
@@ -654,9 +653,8 @@ static void pm_render (void *vdest, unsigned bufflen)
         }
         else if (currevent->data.channel.param1 == 0x79)
         {
-          int i = currevent->data.channel.channel;
-          writeevent (when, 0xB0, i, 0x79, 0x00); // reset all controllers
-          write_volume (when, i, channel_volume[i]); // reapply volume
+          // ms gs synth resets volume if "reset all controllers" value isn't zero
+          writeevent (when, 0xB0, currevent->data.channel.channel, 0x79, 0x00);
           break;
         }
         // fall through