This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stores demo joins as a new special input in the 7th bit of the "buttons" byte. The goal here is to track where segments meet for posterity and to assist with automated demo analysis performed for DSDA.
While this bit was unused in the original lmp format, it is sometimes used as an extra bit for weapon swap extensions (8 = chainsaw, 9 = ssg). This is the case for certain old versions of prboom+ (now achieved with the
-emulate
parameter or a specific flag) and for newer compatibility levels (boom, mbf, etc). In either of those contexts, and when a weapon swap is triggered, this bit must be left alone.While this limitation is unfortunate, it's satisfactory for us to cover the cases we can, and there's only so much you can do without breaking compatibility entirely.
FYI @fabiangreffrath