Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

Track demo joins #97

Merged
merged 1 commit into from Jun 26, 2020
Merged

Track demo joins #97

merged 1 commit into from Jun 26, 2020

Conversation

kraflab
Copy link
Collaborator

@kraflab kraflab commented Jun 13, 2020

This PR stores demo joins as a new special input in the 7th bit of the "buttons" byte. The goal here is to track where segments meet for posterity and to assist with automated demo analysis performed for DSDA.

While this bit was unused in the original lmp format, it is sometimes used as an extra bit for weapon swap extensions (8 = chainsaw, 9 = ssg). This is the case for certain old versions of prboom+ (now achieved with the -emulate parameter or a specific flag) and for newer compatibility levels (boom, mbf, etc). In either of those contexts, and when a weapon swap is triggered, this bit must be left alone.

While this limitation is unfortunate, it's satisfactory for us to cover the cases we can, and there's only so much you can do without breaking compatibility entirely.

FYI @fabiangreffrath

@fabiangreffrath
Copy link
Collaborator

Any idea for a pendant commit in Crispy yet?

@kraflab
Copy link
Collaborator Author

kraflab commented Jun 14, 2020

I should have time to dive into crispy today.

@fabiangreffrath fabiangreffrath merged commit 4348d6d into coelckers:master Jun 26, 2020
@kraflab kraflab deleted the track-demo-joins branch July 28, 2020 20:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants