Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not edit class declarations inside namespaces #101

Conversation

BrianHenryIE
Copy link
Contributor

@BrianHenryIE BrianHenryIE commented Dec 13, 2020

Fix for #93 .

ClassmapReplacer specific.
Short-circuits the regex replacer when a named namespace is found.
Accommodates an explicit global namespace following a named namespace, in which case the classes will be renamed.

@BrianHenryIE BrianHenryIE marked this pull request as draft December 14, 2020 01:55
@BrianHenryIE BrianHenryIE marked this pull request as ready for review December 14, 2020 02:57
@coenjacobs coenjacobs merged commit 5ae829a into coenjacobs:master Jan 17, 2021
@BrianHenryIE BrianHenryIE deleted the Do-not-edit-class-declarations-inside-namespaced-files branch May 3, 2021 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants