Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code quality refactor items #104

Closed
MrOrz opened this issue Apr 29, 2018 · 2 comments
Closed

Code quality refactor items #104

MrOrz opened this issue Apr 29, 2018 · 2 comments

Comments

@MrOrz
Copy link
Member

MrOrz commented Apr 29, 2018 •
edited
Loading

  • Simplify app() HOC: should invoke page components' getInitialProps instead of initFn, directly put bootstrapFn in page component's componentDidMount. Integrate redux stuff to _app.js, since we are migrating to next6 in Update all dependencies #106 . Reference: _app usage , next-redux-wrapper integration & implementation
  • Add storybook for components. Document the properties and setup snapshots. Add the following addons:
    • storyshots
    • storysource
    • info
    • jest
  • Replace all replyConnections with articleReplies
@MrOrz MrOrz changed the title Refactor items Code quality refactor items Apr 29, 2018
@MrOrz
Copy link
Member Author

MrOrz commented Jan 16, 2020

Now app() are replaced by withData, replyConnections are refactored out during rewrite. Only storybook is left.

@MrOrz
Copy link
Member Author

MrOrz commented May 27, 2022

Storybook is online, no actions left

@MrOrz MrOrz closed this as completed May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MrOrz