Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArticlePageLayout refactor #286

Closed
3 tasks done
MrOrz opened this issue Jul 11, 2020 · 0 comments · Fixed by #331
Closed
3 tasks done

ArticlePageLayout refactor #286

MrOrz opened this issue Jul 11, 2020 · 0 comments · Fixed by #331
Assignees

Comments

@MrOrz
Copy link
Member

MrOrz commented Jul 11, 2020

Related bugs

  • Search page 應該 sort by relevance
  • Replied by me filter 目前是壞的
  • Latest reply 頁面卻有沒回應過的訊息

目標

  • 不同頁面使用不同 filter
  • 不同頁面使用不同 sort
  • 不同頁面顯示不同 UI、載入不同資料

進行

ArticlePageLayout (可疑訊息、最新查核、等你來答、搜尋頁面) 的 refactor 預計會這樣進行:
https://g0v.hackmd.io/h8rP0TOGTh2Clxi_Oi_QKw

  1. 會影響列表的 controls (如 filter, search, more button) 直接對 URL param 讀寫。單純化的 component input / output 有利於在各個 page components 重用。
  2. page components 管理 data loading,讀取 URL param 之後拼湊成 graphql query。各頁面有特殊 Query 需求,也是在這個階段對 graphql query 加蔥。
  3. 將會分 3 個 pull request 進 code

進度

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant