Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS compatibility issue #313

Closed
MrOrz opened this issue Aug 15, 2020 · 1 comment · Fixed by #316
Closed

iOS compatibility issue #313

MrOrz opened this issue Aug 15, 2020 · 1 comment · Fixed by #316

Comments

@MrOrz
Copy link
Member

MrOrz commented Aug 15, 2020 •
edited

Current Cofacts's use of Object.fromEntries breaks iOS 11.1 / Safari 11
image

It even doesn't work on iOS 12 / Google Chrome:
image

Previous analysis of mobile browser versions:
https://g0v.hackmd.io/@mrorz/rksKX45D8#LIFF-compatibility

Compatibility:
https://caniuse.com/#feat=mdn-javascript_builtins_object_fromentries

We should target the following versions:

  • Android: Chrome mobile 52.0.2743.98 to cover 99% of sessions
  • iOS: iOS version 10.3 to cover 99% of sessions
@MrOrz
Copy link
Member Author

MrOrz commented Aug 15, 2020 •
edited

Related corejs polyfill: https://github.com/zloirock/core-js/blob/v3.6.5/packages/core-js/modules/es.object.from-entries.js

@MrOrz MrOrz mentioned this issue Aug 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Object.fromEntries polyfill to support iOS Safari 11 cofacts/rumors-site
1 participant
@MrOrz