Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev fixes #6

Merged
merged 14 commits into from Dec 31, 2021
Merged

Dev fixes #6

merged 14 commits into from Dec 31, 2021

Conversation

absorpheus
Copy link
Contributor

Summary:

  • Removed babel dependency/config and replaced with experimental vm modules (jest)
  • Removed a plethora of unused dependencies
  • Removed unnecessary async/await syntax
  • Loads and reads from list.txt (when used as an npm module)
  • Fixed empty string bug
  • Add tests
  • Refactored some of the code

RobertJGabriel
RobertJGabriel approved these changes Dec 31, 2021
View reviewed changes
Copy link
Collaborator

@RobertJGabriel RobertJGabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic, thanks for the clean up. Going to merge it.

@RobertJGabriel RobertJGabriel merged commit d5e3b74 into coffee-and-fun:main Dec 31, 2021
@absorpheus
Copy link
Contributor Author

Thank you for approving and merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertJGabriel RobertJGabriel RobertJGabriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@absorpheus @RobertJGabriel