Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coffee unlink Command #279

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Conversation

tareknaser
Copy link
Collaborator

Description

This pull request adds the coffee unlink command and renames the coffee setup command to coffee link.
Fixes #278

Changes

  • Rename setup Command to link
    • Change function names from setup_* to link_* (e.g., setup_with_cln to link_with_cln)
    • Update command references in httpd and plugin crates
    • Update documentation
  • Add coffee unlink Command
    • Add methods in coffee_core to enable unlinking coffee configuration from CLN configuration
    • Update coffee_cmd crate to include the new unlink command
    • Add documentation for the unlink command

Note: The commits are organized so that the renaming of coffee setup is in one commit, and the addition of coffee unlink is in a separate commit. The clightningrpc-conf from git is required to use the rm_subconf() method.

- Rename `coffee setup` command to `coffee link`
- Change function names from `setup_*` to `link_*` (e.g., `setup_with_cln` to `link_with_cln`)
- Update command references in `httpd` and `plugin` crates
- Modify relevant documentation to reflect the command name change

This refactor is to accommodate the addition of a new `unlink` command.

Signed-off-by: Tarek <tareknaser360@gmail.com>
- Add methods in `coffee_core` to enable unlinking coffee configuration from CLN configuration
- Update `coffee_cmd` crate to support the new `unlink` command
- Add documentation for the new `unlink` command

Note: The `clightningrpc-conf` from git is required to use the `rm_subconf()` method.

Signed-off-by: Tarek <tareknaser360@gmail.com>
Copy link

netlify bot commented May 29, 2024

Deploy Preview for coffee-docs canceled.

Name Link
🔨 Latest commit c3f842c
🔍 Latest deploy log https://app.netlify.com/sites/coffee-docs/deploys/666323f825b4620008faa1cd

Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 20be671

Thanks!

@vincenzopalazzo
Copy link
Contributor

ops CI shows a break

    Checking brotli v3.4.0
   Compiling derive_more v0.99.17
error[E0282]: type annotations needed for `Box<_>`
Error:   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.34/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++

   Compiling actix-router v0.5.2
For more information about this error, try `rustc --explain E0282`.
error: could not compile `time` (lib) due to 1 previous error

@tareknaser
Copy link
Collaborator Author

tareknaser commented May 29, 2024

Hmmm
It looks like the error is in the nightly build and appears to be a dependency issue, which doesn't seem related to this PR.

Update
Just noticed I got the same error on master branch CI: https://github.com/tareknaser/coffee/actions/runs/9190931675/job/25276264891

Let me investigate this further

@vincenzopalazzo vincenzopalazzo marked this pull request as draft June 1, 2024 07:50
Signed-off-by: Tarek <tareknaser360@gmail.com>
@tareknaser tareknaser marked this pull request as ready for review June 7, 2024 15:18
Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c3f842c

@vincenzopalazzo vincenzopalazzo merged commit 3d3661a into coffee-tools:master Jun 7, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd: add the possibility to unlinks the core lightning form coffee
2 participants