Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urlpreview: Error in urlpreview regexp #9

Closed
ajkessel opened this issue Aug 25, 2023 · 1 comment · Fixed by #10
Closed

urlpreview: Error in urlpreview regexp #9

ajkessel opened this issue Aug 25, 2023 · 1 comment · Fixed by #10

Comments

@ajkessel
Copy link
Contributor

The urlpreview regexp is grabbing the closing parenthesis in markdown syntax and thus failing when attempting to preview. If the user posts a URL in the form of text

[text](https://link.com)

The closing parenthesis after .com gets pulled in and the preview fails.
@coffeebank coffeebank changed the title error in urlpreview regexp urlpreview: Error in urlpreview regexp Aug 27, 2023
coffeebank added a commit that referenced this issue Aug 27, 2023
@coffeebank
urlpreview: Exclude parentheses from url
8db2595 
Fix #9
@coffeebank coffeebank mentioned this issue Aug 27, 2023
Merged
2 tasks
@ajkessel
Copy link
Contributor Author

Thanks for fixing this so quickly. Is it necessary to limit URLs to https? In my copy, I added a ? after s in the regexp.

@coffeebank coffeebank mentioned this issue Aug 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

urlpreview: v0.2.1 release coffeebank/coffee-maubot
1 participant
@ajkessel