You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm quite unhappy with current implementation of frames/no-frames view. I agree it could be useful for someone to have non-frame view but I can't agree it's enabled by default and there's no way to change this behavior nor to exclude non-frame view completely.
I was going to split it into two separate templates if it's ok. Is it?
The text was updated successfully, but these errors were encountered:
I would not drop it, instead make the behavior configurable.
That's a good opportunity to clean up the Generator class, it's currently a mess: The index page is generated by Generator#generateReadme and in fact it's again created in Generator#generateExtras, just with a different output name.
I suggest to rename Generator#generateIndex to Generator#generateClassIndex, so we can introduce again Generator#generateIndex, but this time it really generates the index page :P
The index page then can then be configured:
Frames (default) or no frames
The index file (defaults to the README)
Enable (default) or disable frame/no frame switcher.
I'm not sure if adding one more configuration level on top of ability to switch templates is a good idea. I'm up for refactoring but we should think twice if we really want this kind of configuration.
I'm quite unhappy with current implementation of frames/no-frames view. I agree it could be useful for someone to have non-frame view but I can't agree it's enabled by default and there's no way to change this behavior nor to exclude non-frame view completely.
I was going to split it into two separate templates if it's ok. Is it?
The text was updated successfully, but these errors were encountered: