Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Uniqueness: Support IDNs and improve uniqueness handling #468

Closed
HeyJoel opened this issue Nov 30, 2021 · 1 comment
Closed

Email Uniqueness: Support IDNs and improve uniqueness handling #468

HeyJoel opened this issue Nov 30, 2021 · 1 comment
Milestone

Comments

@HeyJoel
Copy link
Member

HeyJoel commented Nov 30, 2021

  • Email uniqueness checks aren't enforced in the domain, only usernames. This causes an issue if emails aren't used for usernames
  • Email constraints are not case-sensitive, but they should be for the local part of the email. The domain should not be case sensitive but should try and support IDNs.
  • It would be good to add a service for formatting email / domains for uniqueness checks e.g. test@googlemail.com and t.est+123@gmail.com are the same address. The base rules should probably be minimal to avoid false-positives, but should be able to be upgraded via extension/override. Note that uniquification should not be applied to the email address used for notifications, as the original format should be honored.
@HeyJoel HeyJoel added the bug label Nov 30, 2021
@HeyJoel HeyJoel added this to the 0.10 milestone Nov 30, 2021
HeyJoel added a commit that referenced this issue Dec 3, 2021
@HeyJoel
Copy link
Member Author

HeyJoel commented Dec 3, 2021

Fixed, will be released in v0.10. Guidance on customizing the formatting of emails and usernames for uniqueness checks will be added to the docs.

@HeyJoel HeyJoel closed this as completed Dec 3, 2021
@HeyJoel HeyJoel added enhancement and removed bug labels Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant