Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add graph neural networks #110

Merged
merged 35 commits into from
Feb 8, 2024
Merged

add graph neural networks #110

merged 35 commits into from
Feb 8, 2024

Conversation

zshiqiang
Copy link
Collaborator

Legal Acknowledgement
By contributing to this software project, I agree my contributions are submitted under the BSD license.
I represent I am authorized to make the contributions and grant the license.
If my employer has rights to intellectual property that includes these contributions,
I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@zshiqiang zshiqiang marked this pull request as ready for review June 8, 2023 16:09
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a3d128d) 91.67% compared to head (72b9f65) 92.55%.

❗ Current head 72b9f65 differs from pull request most recent head 26b8522. Consider uploading reports for the commit 26b8522 to get more accurate results

Files Patch % Lines
.../omlt/io/torch_geometric/torch_geometric_reader.py 99.17% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   91.67%   92.55%   +0.88%     
==========================================
  Files          29       32       +3     
  Lines        1730     1948     +218     
  Branches      327      373      +46     
==========================================
+ Hits         1586     1803     +217     
  Misses         74       74              
- Partials       70       71       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/omlt/neuralnet/layers/__init__.py Outdated Show resolved Hide resolved
src/omlt/neuralnet/layer.py Show resolved Hide resolved
src/omlt/neuralnet/layer.py Outdated Show resolved Hide resolved
Copy link
Member

@rmisener rmisener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all the changes! Excited about this PR.

@rmisener rmisener requested review from rmisener and jezsadler and removed request for jezsadler and rmisener December 8, 2023 14:56
@rmisener rmisener merged commit 72a0366 into cog-imperial:main Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants