mark binomial_exact() function for removal #1731
Labels
Comments
GavinHuttley
added
help wanted
GavinHuttley
changed the title
|
I would like to do this issue. |
ChangsenJiang
added a commit
to ChangsenJiang/cogent3
that referenced
this issue
Mar 13, 2024
cogent3#1731 In this commit, the binomial_exact() function was removed and the related test_binomial_series(), test_binomial_exact(), test_binomial_exact_floats(), and test_binomial_exact_errors() were also been removed
Closed
ChangsenJiang
added a commit
to ChangsenJiang/cogent3
that referenced
this issue
Mar 13, 2024
cogent3#1731 In this new commit, we revert the change within the function to the original, and delete the new import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What should be changed
cogent3.maths.stats.binomial_exact()Why
Not used in cogent3, available in scipy.stats?
How much notice
6 months notice. This should be represented in the user warning as a specific version. e.g. .<current month + x> where x is from the PR date.
Guidelines for deprecation
As this is a function that will be removed, see dev guidelines for deprecation of code. Indicate the limiting version (for when the old function will be removed) as the number above from when you make the change.
The text was updated successfully, but these errors were encountered: