Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow external config for cog_validate #206

Merged
merged 3 commits into from Jun 21, 2021
Merged

allow external config for cog_validate #206

merged 3 commits into from Jun 21, 2021

Conversation

vincentsarago
Copy link
Member

@vincentsarago vincentsarago commented Jun 18, 2021 •
edited

Before we were forcing GDAL_DISABLE_READDIR_ON_OPEN=FALSE for validation. With this PR we let the user decide what env to set.

TODO

  • add a note about the link between env variable and validation result

cc @JoakimJoensuu

@JoakimJoensuu
Copy link

JoakimJoensuu commented Jun 18, 2021 •
edited

Just tried it on my project. Works like a charm!

@JoakimJoensuu JoakimJoensuu mentioned this pull request Jun 18, 2021
Closed
@vincentsarago vincentsarago merged commit 600641b into master Jun 21, 2021
@vincentsarago vincentsarago deleted the externalConfigCogValidate branch June 21, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoakimJoensuu JoakimJoensuu JoakimJoensuu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vincentsarago @JoakimJoensuu