change how blocksize is defined in create CLI #283
Conversation
|
@alexismanin let me know if you can 👀 this PR 🙏 |
| "GDAL_TIFF_OVR_BLOCKSIZE env or 128)", | ||
| show_default=True, | ||
| help="Overview's internal tile size (default can be defined by " | ||
| "GDAL_TIFF_OVR_BLOCKSIZE env). The default is 128, or starting with GDAL 3.1 to use the same block size as the full-resolution dataset if possible).", |
There was a problem hiding this comment.
remove default in the CLI
rio_cogeo/scripts/cli.py
Outdated
| tilematrixset.matrix(tilematrixset.minzoom).tileHeight, | ||
| tilematrixset.matrix(tilematrixset.minzoom).tileWidth, | ||
| ) | ||
| overview_blocksize = overview_blocksize or blocksize |
There was a problem hiding this comment.
- use TMS tileHeight or tileWidth if
blocksizeis not provided - overview blocksize default to
blocksizeif not provided (only when there is a tilematrixset option)
There was a problem hiding this comment.
tilematrix.matrix(tilematrixset.minzoom) gives the lowest-resolution matrix, whereas tilematrix.matrix(tilematrixset.minzoom) returns the best level of details. Therefore, I would tend to define blocksize using tilematrix.matrix(tilematrixset.maxzoom), and keep the minzoom one for overview block size.
Now, I am not sure it matters in practice, because I have not seen any tile-matrix set changing tile size between levels (and in such case, looking at only the min and max level would not be enough anyway).
There was a problem hiding this comment.
most TMS should have the same tileHeight and tileWidth at all level (at least for the common grids), ideally we would select the blocksize for the zoom level the data cover but we can't get this in the CLI
| raster_path_gcps, | ||
| ], | ||
| ) | ||
| def test_cogeo_info(src_path, runner): |
There was a problem hiding this comment.
not related to this PR main goal
I will give a quick look at it. |
| click.secho( | ||
| f"Defining `blocksize` from {tilematrixset.id} TileMatrixSet `tileWidth` and `tileHeight`", | ||
| fg="yellow", | ||
| ) |
There was a problem hiding this comment.
we only print a warning if blocksize wasn't defined
| f"Defining overview's `blocksize` to match the high resolution `blocksize`: {blocksize}", | ||
| fg="yellow", | ||
| ) | ||
| overview_blocksize = blocksize |
vincentsarago
deleted the
features/refactor-blocksize-definition-in-cli
branch
ref #279 (review)
closes #280