add Validate function #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillies
reviewed
Apr 5, 2018
sgillies
reviewed
Apr 5, 2018
added 7 commits
April 5, 2018 10:58
added 2 commits
June 13, 2018 13:46
Conflicts: README.rst rio_cogeo/__init__.py
|
@vincentsarago @perrygeo test coverage of the validation code is low, but it installs and it works. We should start using it in the great migration. |
|
@sgillies right now the validate function is missing the part to validate if the overview are tiled: rasterio/rasterio#1375 I'd love to get this before merging the validate method |
|
Oh right, I was only looking at the top comment, which referred to #1305 (closed). I'll fix that. |
vincentsarago
assigned vincentsarago, perrygeo and sgillies and unassigned vincentsarago
|
Update: this will be possible when rasterio/rasterio#1504 is done ;-) |
|
I think there is a solution here to check if the overview are tiled by using the solution mentioned by @sgillies in https://rasterio.groups.io/g/dev/topic/26793684#15 rasterio.open("example.tif", OVERVIEW_LEVEL=0) as src:
src.is_tiled or src.block_shapes |
vincentsarago
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a
validatemethod which is a strict copy of https://svn.osgeo.org/gdal/trunk/gdal/swig/python/samples/validate_cloud_optimized_geotiff.pyNote: This won't work until rasterio/rasterio#1375 get merged