Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check blocksize and adapt if raster is too small #82

Merged
merged 2 commits into from Jul 17, 2019
Merged

check blocksize and adapt if raster is too small #82

merged 2 commits into from Jul 17, 2019

Conversation

vincentsarago
Copy link
Member

close #80

This PR adds a check to make sure blocksize is not bigger than the smaller raster dimension (width/height).
If blocksize is bigger, cog_translate will select smaller blocksize down to 64px

@vincentsarago vincentsarago mentioned this pull request Jul 14, 2019
Closed
DanSchoppe
DanSchoppe approved these changes Jul 15, 2019
View reviewed changes
Copy link

@DanSchoppe DanSchoppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, @vincentsarago! 😄

@alando46
Copy link

Agreed, this looks really good. Thanks so much @vincentsarago!!

@vincentsarago vincentsarago merged commit 4c6e890 into master Jul 17, 2019
@vincentsarago vincentsarago mentioned this pull request Jul 17, 2019
Closed
@vincentsarago vincentsarago deleted the validBlocksize branch September 4, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanSchoppe DanSchoppe DanSchoppe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rio cogeo create fails when converting sentinel-2 preview files
3 participants
@vincentsarago @alando46 @DanSchoppe