Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken function parameters to File and Events #156

Closed
sceniclife opened this issue Jan 27, 2021 · 3 comments · Fixed by #157
Closed

Broken function parameters to File and Events #156

sceniclife opened this issue Jan 27, 2021 · 3 comments · Fixed by #157

Comments

@sceniclife
Copy link
Contributor

cognite-replicator/cognite/replicator/replication.py

Line 362 in c2d70d5

exclude_fields,

@jorge-sanchez-2020
@gaetan-h
@petreeb

Hey, FYI, the replication.thread function is shared by TimeSeries, File, and Events. If you change the signature parameters here, you NEED to change it in timeseries.py, files.py, and events.py

It was only changed in timeseries.py. Files and Event replication is currently broken.
5380a21
@sceniclife sceniclife linked a pull request Jan 27, 2021 that will close this issue
fix(copy): fix files and events copy #157
Merged
@gaetan-h
Copy link
Contributor

@jorge-sanchez-2020 can you look into this? Thanks

@sceniclife
Copy link
Contributor Author

I've already made the fix in the attached PR.

@gaetan-h
Copy link
Contributor

gaetan-h commented Jan 27, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(copy): fix files and events copy cognitedata/cognite-replicator
2 participants
@sceniclife @gaetan-h