Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update replication.py #123

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Update replication.py #123

merged 2 commits into from
Mar 10, 2020

Conversation

gaetan-h
Copy link
Contributor

thanks for finding the bug
dst_ts was not declared in the thread function
i have declared it now and it should be passed to the copy function
Please test (with low batch size) and let me know

@cognite-cicd
Copy link

Checkmarx scan completed with the following findings

Lines Severity Category File Link

@jenkins-cognite
Copy link

[pr-bot]
Run this build with docker run --rm -it cognite/cognite-replicator-dev:pr-123

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #123   +/-   ##
======================================
  Coverage    42.4%   42.4%           
======================================
  Files          10      10           
  Lines         724     724           
======================================
  Hits          307     307           
  Misses        417     417
Impacted Files Coverage Δ
cognite/replicator/replication.py 76.56% <ø> (ø) ⬆️

@copperwire
Copy link

Tested with a batch size of 100, works fine.

@gaetan-h
Copy link
Contributor Author

gaetan-h commented Feb 26, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants