Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add codeSnippets/ to .gitignore #376

Merged
merged 1 commit into from
Jun 19, 2020
Merged

chore: add codeSnippets/ to .gitignore #376

merged 1 commit into from
Jun 19, 2020

Conversation

haved
Copy link
Contributor

@haved haved commented Jun 19, 2020

No description provided.

@haved haved requested review from a team June 19, 2020 08:31
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #376 into v1 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##               v1     #376   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files          54       54           
  Lines        1652     1652           
  Branches      185      185           
=======================================
  Hits         1586     1586           
  Misses         64       64           
  Partials        2        2           

Copy link
Collaborator

@polomani polomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, but this is not a fix (it doesn't require a new release), but rather a chore

@haved haved changed the title fix: add codeSnippets/ to .gitignore chore: add codeSnippets/ to .gitignore Jun 19, 2020
@haved
Copy link
Contributor Author

haved commented Jun 19, 2020

I changed the title of the pr, is that sufficient if it's squash merged?

@polomani
Copy link
Collaborator

polomani commented Jun 19, 2020

@haved we can rename yes, but just for the future
as we don't always squash

@polomani polomani merged commit 2e6a4e2 into v1 Jun 19, 2020
@polomani polomani deleted the gitignore_snippets branch June 19, 2020 11:56
@cognite-cicd
Copy link
Contributor

🎉 This PR is included in version 2.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants