Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

immutable props #1821

Merged
merged 4 commits into from
Jun 25, 2024
Merged

immutable props #1821

merged 4 commits into from
Jun 25, 2024

Conversation

erlendvollset
Copy link
Collaborator

  • DMS: Support immutable properties
  • Bump version and update changelog

Description

Please describe the change you have made.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@doctrino doctrino marked this pull request as ready for review June 25, 2024 06:53
@doctrino doctrino requested review from a team as code owners June 25, 2024 06:53
@doctrino doctrino requested review from roligheten and removed request for a team June 25, 2024 06:53
@doctrino doctrino self-requested a review June 25, 2024 06:55
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (c4ef3cd) to head (b4bd2eb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1821      +/-   ##
==========================================
- Coverage   92.88%   92.80%   -0.08%     
==========================================
  Files         121      121              
  Lines       17850    17853       +3     
==========================================
- Hits        16580    16569      -11     
- Misses       1270     1284      +14     
Files Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
...te/client/data_classes/data_modeling/containers.py 98.81% <100.00%> (+0.01%) ⬆️
cognite/client/data_classes/data_modeling/views.py 92.81% <100.00%> (+0.01%) ⬆️

... and 6 files with indirect coverage changes

@erlendvollset erlendvollset merged commit e191223 into master Jun 25, 2024
14 checks passed
@erlendvollset erlendvollset deleted the immutable-props branch June 25, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants