Neat 301 bug duplicated edge external ids (#492)

* fix bug with duplicated edge ids * bump version added changelog
cognitedata · Jun 11, 2024 · 1a48556 · 1a48556
1 parent 251e585
commit 1a48556
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 4 deletions.
diff --git a/Makefile b/Makefile
@@ -1,5 +1,5 @@
 .PHONY: run-explorer run-tests run-linters build-ui build-python build-docker run-docker compose-up
-version="0.80.0"
+version="0.80.1"
 run-explorer:
 	@echo "Running explorer API server..."
 	# open "http://localhost:8000/static/index.html" || true

diff --git a/cognite/neat/_version.py b/cognite/neat/_version.py
@@ -1 +1 @@
-__version__ = "0.80.0"
+__version__ = "0.80.1"
diff --git a/cognite/neat/legacy/rules/exporters/_rules2pydantic_models.py b/cognite/neat/legacy/rules/exporters/_rules2pydantic_models.py
@@ -685,7 +685,7 @@ def is_external_id_valid(external_id: str) -> bool:
 
                 edge = EdgeApply(
                     space=data_model.views[view_id].space,
-                    external_id=f"{self.external_id}-{end_node_external_id}",
+                    external_id=f"{self.external_id}-{edge_one_to_many}-{end_node_external_id}",
                     type=(data_model.views[view_id].space, edge_type_id),
                     start_node=(data_model.views[view_id].space, self.external_id),
                     end_node=(data_model.views[view_id].space, end_node_external_id),

diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -16,6 +16,11 @@ Changes are grouped as follows:
 - `Security` in case of vulnerabilities.
 
 
+## [0.80.1] - 11-06-24
+### Fixed
+- Fixed issues with duplicated edges when different properties are referring to the same target node.
+
+
 ## [0.80.0] - 10-06-24
 
 ### Improved

diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "cognite-neat"
-version = "0.80.0"
+version = "0.80.1"
 readme = "README.md"
 description = "Knowledge graph transformation"
 authors = [