Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEAT-208] Pydantic v2 model_copy instead of copy #416

Merged
merged 4 commits into from
Apr 26, 2024
Merged

[NEAT-208] Pydantic v2 model_copy instead of copy #416

merged 4 commits into from
Apr 26, 2024

Conversation

doctrino
Copy link
Collaborator

Does not look good when users imports a model and is met with this:
image

@doctrino doctrino marked this pull request as ready for review April 25, 2024 18:31
@doctrino doctrino requested a review from a team as a code owner April 25, 2024 18:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
18766 12499 67% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite/neat/_version.py 100% 🟢
cognite/neat/rules/exporters/_rules2dms.py 68% 🟢
cognite/neat/rules/models/rules/_dms_architect_rules.py 91% 🟢
cognite/neat/rules/models/rules/_domain_rules.py 98% 🟢
cognite/neat/rules/models/rules/_information_rules.py 89% 🟢
TOTAL 89% 🟢

updated for commit: 6f423d6 by action🐍

@doctrino
Merge remote-tracking branch 'origin/main' into pydantic-copy-warning
02592b9 
# Conflicts:
#	docs/CHANGELOG.md
#	tests/tests_unit/rules/test_exporters/test_rules2excel.py
@doctrino
build; bump
6f423d6
@doctrino doctrino merged commit e400507 into main Apr 26, 2024
7 checks passed
@doctrino doctrino deleted the pydantic-copy-warning branch April 26, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikokaoja nikokaoja nikokaoja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@doctrino @nikokaoja