Neat 206 delete dms data model step is missing in v2 rules #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
doctrino
approved these changes
Apr 30, 2024
| @@ -87,8 +87,10 @@ def retrieve(self, ids: SequenceNotStr[str]) -> SpaceList: | |||
| def update(self, items: Sequence[SpaceApply]) -> SpaceList: | |||
| return self.create(items) | |||
|
|
|||
| def delete(self, ids: SequenceNotStr[str]) -> list[str]: | |||
| return self.client.data_modeling.spaces.delete(ids) | |||
| def delete(self, ids: SequenceNotStr[str] | Sequence[Space | SpaceApply]) -> list[str]: | |||
There was a problem hiding this comment.
Suggest adding a technical debt task (unless you want to tackle it immediately) on moving this to the base class.
nikokaoja
deleted the
NEAT-206-DeleteDMSDataModel-step-is-missing-in-V2-rules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[0.75.7] - 29-05-24
Added
DMSExporternow supports deletion of data model and data model componentsDeleteDataModelFromCDFadded to the step library