Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neat 256 create serializer module for information rules #456

Merged
merged 2 commits into from
May 15, 2024
Merged

Neat 256 create serializer module for information rules #456

merged 2 commits into from
May 15, 2024

Conversation

nikokaoja
Copy link
Collaborator

@nikokaoja nikokaoja commented May 15, 2024 •
edited
Loading

  • Moved serializer to dedicated module

@nikokaoja nikokaoja marked this pull request as ready for review May 15, 2024 13:03
@nikokaoja nikokaoja requested a review from a team as a code owner May 15, 2024 13:03
@nikokaoja nikokaoja changed the title Neat 256 create serializer module for information rules 🎓 Neat 256 create serializer module for information rules May 15, 2024
@nikokaoja nikokaoja changed the title 🎓 Neat 256 create serializer module for information rules Neat 256 create serializer module for information rules May 15, 2024
@github-actions GitHub Actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
20287 13840 68% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite/neat/rules/models/information/_rules.py 84% 🟢
cognite/neat/rules/models/information/_serializer.py 83% 🟢
TOTAL 83% 🟢

updated for commit: 8309781 by action🐍

@nikokaoja nikokaoja merged commit fd18985 into main May 15, 2024
7 checks passed
@nikokaoja nikokaoja deleted the NEAT-256-Create-Serializer-module-for-InformationRules branch May 15, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doctrino doctrino doctrino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nikokaoja @doctrino