Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Mapbox plugin v10 #762

Open
cohenadair opened this issue Sep 4, 2022 · 1 comment
Open

Update to Mapbox plugin v10 #762

cohenadair opened this issue Sep 4, 2022 · 1 comment

Comments

@cohenadair
Copy link
Owner

cohenadair commented Sep 4, 2022

This ticket is now to migrating to the official Mapbox Flutter plugin.


========== UPDATED 6

Things seem to be working with the updated legacy plugin. Nothing to do for now.

========== UPDATED 5

The crash was not fixed with Flutter 3.7; however, it is apparently fixed with an update to the old Mapbox plugin: flutter-mapbox-gl/maps#1293

If true, this issue can be deferred to next release.

========== UPDATED 4

Apparently, the crash is fixed with Flutter 3.7 and a Mapbox MR: flutter-mapbox-gl/maps#1119 (comment)

The fix should be tested and if it works, we can delay updating to the official Mapbox plugin; perhaps until it is out of beta.

========== UPDATED 3

Official plugin is available here: https://pub.dev/packages/mapbox_maps_flutter

========== UPDATED 2

Putting this issue on hold as an official Mapbox Flutter plugin has been announced: flutter-mapbox-gl/maps#691 (comment)

Will come back to this if the official plugin falls through. Note that switching to v10 doesn't necessarily mean the original crash will be fixed. We will have to see.

E: Temporarily, the crash could be fixed by flutter-mapbox-gl/maps#1172. E2: Unfortunately, the workaround did not work for me.

========== UPDATED

Due to the crash, and Mapbox dropping support for old SDK, we'll implement a custom v10 plugin with the minimum functionality needed for Anglers' Log.

========== ORIGINAL

Due to new native crash in Flutter 3:

Workaround is to set Mapbox's myLocationEnabled to false. We'll do this, and add a custom marker for the user's current location. Update: This may not be a complete workaround since the Mapbox examples already have myLocationEnabled set to false. Some more testing is needed.

This happens every time a catch is added (caused by pushing/popping MapboxMap widgets to/from the stack), or a single fishing spot is opened (from catch details), then popped off the stack.

@cohenadair
Copy link
Owner Author

For now, going to defer this until this is fixed in Flutter.

@cohenadair cohenadair changed the title Use custom "my location" button for Android Switch to custom Mapbox plugin to support v10 Oct 11, 2022
@cohenadair cohenadair changed the title Switch to custom Mapbox plugin to support v10 Update to Mapbox plugin v10 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant