Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trip data still reset after selecting catches while editing a trip #836

Closed
cohenadair opened this issue Jun 20, 2023 · 0 comments
Closed
Labels

Comments

@cohenadair
Copy link
Owner

cohenadair commented Jun 20, 2023

Reproduction Steps

  1. Start a new trip
  2. Add Catches Per Entity for all entities
  3. Save the Trip
  4. Edit the Trip
  5. Select a few catches

Expected Result

  • None of the catches per entity fields are changed

Actual Result

  • All the catches per entity fields are changed

This is because the user must edit the catches per entity in the current edit session for them to be skipped when picking catches.

Two possible solutions:

  1. There are cases where users edit a trip and select more catches and want those fields to update, so perhaps we need to add new protobuf fields to track if the user explicitly set the catches per entity fields, so we can check on subsequent trip edits.
  2. Another approach could be to ask the user if they want to override existing fields, which should apply to any field that is automatically updated after picking catches. Complication, though -- what if they want to override some fields, but not others -- it might be overkill to ask them which fields they want to change.
  3. At the top of SaveTripPage, include a checkbox that explains that if checked, X fields will be calculated based on the catch selection.

Option 3 seems the best. If there's one or more fields they don't want overridden, they can uncheck the box for this trip.

@cohenadair cohenadair added the bug label Jun 20, 2023
@cohenadair cohenadair changed the title Catches per entity still reset when editing a Trip Trip data still reset after selecting catches while editing a trip Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant