Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add experimental co.rerank API #146

Merged
merged 1 commit into from Feb 2, 2023
Merged

Add experimental co.rerank API #146

merged 1 commit into from Feb 2, 2023

Conversation

lfayoux
Copy link
Contributor

@lfayoux lfayoux commented Feb 1, 2023

This PR adds support for the experimental co.rerank API. Access to this API is limited to a small number of users, who will be using the Python SDK.

@lfayoux lfayoux requested a review from a team as a code owner February 1, 2023 16:39
1vn
1vn approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@1vn 1vn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lfayoux lfayoux requested a review from mkozakov February 1, 2023 17:07
mkozakov
mkozakov reviewed Feb 1, 2023
View reviewed changes
cohere/rerank.py Outdated Show resolved Hide resolved
mkozakov
mkozakov approved these changes Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@mkozakov mkozakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make sure we have docstrings for any classes that would be exposed to the user

@lfayoux lfayoux force-pushed the rerank branch 2 times, most recently from baa0b9c to b6b8c33 Compare February 1, 2023 17:49
@lfayoux lfayoux requested review from mahjongmen and mkozakov and removed request for mahjongmen and co-sylvie February 1, 2023 17:49
amorisot
amorisot reviewed Feb 1, 2023
View reviewed changes
cohere/client.py Outdated Show resolved Hide resolved
amorisot
amorisot reviewed Feb 1, 2023
View reviewed changes
cohere/client.py Outdated Show resolved Hide resolved
amorisot
amorisot reviewed Feb 1, 2023
View reviewed changes
cohere/rerank.py Outdated Show resolved Hide resolved
sebastian-hofstaetter
sebastian-hofstaetter approved these changes Feb 2, 2023
View reviewed changes
Copy link

@sebastian-hofstaetter sebastian-hofstaetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lfayoux lfayoux merged commit 6e5a272 into main Feb 2, 2023
@lfayoux lfayoux deleted the rerank branch February 2, 2023 21:11
vshmyhlo pushed a commit that referenced this pull request Feb 21, 2023
@lfayoux
add rerank endpoint (#146)
68d1cd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amorisot amorisot amorisot left review comments

@1vn 1vn 1vn approved these changes

@sebastian-hofstaetter sebastian-hofstaetter sebastian-hofstaetter approved these changes

@mahjongmen mahjongmen mahjongmen approved these changes

@mkozakov mkozakov Awaiting requested review from mkozakov

@co-sylvie co-sylvie Awaiting requested review from co-sylvie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lfayoux @mkozakov @1vn @sebastian-hofstaetter @mahjongmen @amorisot