New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enter to continue on env var review #133

Merged

scott-cohere merged 1 commit into main from scott/cli-improvements

May 14, 2024

Contributor

scott-cohere commented May 11, 2024 •

edited

Thank you for contributing to the Cohere Toolkit!

PR title: "area: description"
- Where "area" is whichever of interface, frontend, model, tools, backend, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes.
- Example: "deployment: add Azure model option"

Multiple people said it's confusing once they arrive at the variable review section of the CLI.

Add tests and docs: Please include testing and documentation for your changes
Lint and test: Run make lint and make run-tests


          update cli lang

eaa5020

scott-cohere requested review from EugeneLightsOn, malexw, scottmx81, tianjing-li and a team as code owners

May 11, 2024 19:38

scott-cohere temporarily deployed to development

May 11, 2024 19:38

— with

GitHub Actions Inactive

lusmoura approved these changes

View reviewed changes

scott-cohere merged commit 665a264 into main

2 checks passed

scott-cohere deleted the scott/cli-improvements branch

May 14, 2024 15:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lusmoura lusmoura approved these changes

EugeneLightsOn Awaiting requested review from EugeneLightsOn EugeneLightsOn is a code owner

malexw Awaiting requested review from malexw malexw is a code owner

scottmx81 Awaiting requested review from scottmx81 scottmx81 is a code owner

tianjing-li Awaiting requested review from tianjing-li tianjing-li is a code owner