Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh skeleton #1

Merged
merged 214 commits into from
Apr 18, 2024
Merged

Refresh skeleton #1

merged 214 commits into from
Apr 18, 2024

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Apr 17, 2024

No description provided.

jaraco and others added 30 commits September 11, 2019 11:25
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
* Require toml extra for setuptools_scm

setuptools_scm does not know to invoke itself
if it can't read pyproject.toml.  This broke
sdist installs for projects deriving from skeleton:

  $ python -m pip install zipp --no-binary zipp
  Collecting zipp
    [...]
  Successfully installed zipp-0.0.0

Note the version number defaulting to '0.0.0'.
Building locally only works because pep517,
the build tool, depends on toml which it exposes
to the build environment.

* Require setuptools_scm 3.4.1 at a minimum

A bare

  [tool.setuptools_scm]

does not work in 3.4.0.

* fixup! Require toml extra for setuptools_scm

* fixup! Require setuptools_scm 3.4.1 at a minimum
In order to generate a wheel in accordance with PEP 425 to restrict the
minimum required version of Python (3.6), the `python-tag` bdist_wheel
option needs to be specified so the wheel gets tagged properly.

Before:
	zipp-x.x.x-py3-none-any.whl
After:
	zipp-x.x.x-py36-none-any.whl

Signed-off-by: Vincent Fazio <vfazio@xes-inc.com>
…/tox-venv#48 (comment)) and tox-pip-version was only there to support tox-venv. venv is dead; long live virtualenv.
Copy link
Member

@diogobaeder diogobaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few suggestions which are optional, but overall it looks good to me. Thanks for the changes!

docs/history.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
towncrier.toml Show resolved Hide resolved
@diogobaeder diogobaeder merged commit da73e24 into main Apr 18, 2024
28 checks passed
@diogobaeder diogobaeder deleted the refresh-skeleton branch April 18, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet