Python SDK for Cluster Version 6.5.1 #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports are APIs supported by 6.5.1 cluster. Multicluster clients are also supported.
pyashish
reviewed
Aug 27, 2020
| @@ -1341,7 +1336,7 @@ def delete_reducer(self, id): | |||
| Returns delete status upon completion. | |||
|
|
|||
| Args: | |||
| id (long|int) | |||
| id (long|int): TODO: Type description here. | |||
| @@ -0,0 +1,8 @@ | |||
| { | |||
There was a problem hiding this comment.
Have removed in the second commit i added, it was created while generating doc with payload for import/export.
| @@ -2322,7 +2436,10 @@ def get_virtual_disk_information(self, cluster_id, cluster_incarnation_id, | |||
| 'jobId': job_id, | |||
| 'jobRunId': job_run_id, | |||
| 'startTimeUsecs': start_time_usecs, | |||
| 'sourceId': source_id | |||
| 'sourceId': source_id, | |||
There was a problem hiding this comment.
I know this took patience, thanks for converting these correctly.
| # -*- coding: utf-8 -*- | ||
| # Copyright 2020 Cohesity Inc. | ||
|
|
||
| import cohesity_management_sdk.models.fleet_tag |
There was a problem hiding this comment.
y not just name aws_fleet_params.py ?
There was a problem hiding this comment.
there is already a module names as aws_fleet_params.py
We have two definitions AWSFleetParams and AwsFleetParams
There was a problem hiding this comment.
aren't they the same models ?
| @@ -225,7 +230,7 @@ class Cluster(object): | |||
| } | |||
|
|
|||
| def __init__(self, | |||
| apps_settings=None, | |||
There was a problem hiding this comment.
This would break backward compatibility right ? or was this an optional parameter ?
There was a problem hiding this comment.
Its is an optional field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports are APIs supported by 6.5.1 cluster.
Multicluster clients are also supported.