Skip to content

Commit

Permalink
Changed variable name for multiplexed clients
Browse files Browse the repository at this point in the history
The variable maxNumClients was unused, while connectionsPerClient was
used for spawning multiple proxyPairs. The former is a more appropriate
name for the multiplexing behaviour we use it for.

Multiplexing now just works thanks to implementing ticket #31310.
  • Loading branch information
cohosh committed Oct 31, 2019
1 parent 64b66c8 commit 300a23c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions proxy/config.js
Expand Up @@ -24,8 +24,6 @@ Config.prototype.defaultBrokerPollInterval = 300.0 * 1000;

Config.prototype.maxNumClients = 1;

Config.prototype.connectionsPerClient = 1;

// TODO: Different ICE servers.
Config.prototype.pcConfig = {
iceServers: [
Expand Down
2 changes: 1 addition & 1 deletion proxy/snowflake.js
Expand Up @@ -119,7 +119,7 @@ class Snowflake {
}

makeProxyPair() {
if (this.proxyPairs.length >= this.config.connectionsPerClient) {
if (this.proxyPairs.length >= this.config.maxNumClients) {
return null;
}
var pair;
Expand Down

0 comments on commit 300a23c

Please sign in to comment.