Fix Replay Sync Checkbox #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantaylor
commented
Feb 23, 2024
| @@ -96,7 +96,7 @@ async fn authenticate<R: Runtime>(handle: AppHandle<R>) -> Result<String> { | |||
| *state.request.lock().await = Some(request); | |||
|
|
|||
| info!("redirecting to auth URL: {auth_url}"); | |||
| open(&handle.shell_scope(), auth_url.clone(), None).map_err(Shell); | |||
| open(&handle.shell_scope(), auth_url.clone(), None).map_err(Shell)?; | |||
There was a problem hiding this comment.
The ? here just makes sure any error halts execution and propagates up to the caller (without it the error is swallowed).
This call really shouldn't ever fail though so it probably doesn't actually make a difference here.
petrvecera
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My initial implementation of the sync checkbox on the backend was broken; these changes fix it. Tested manually with custom games and looks to be solid now.