Improper handling of download_url parameter

[cardil]

download_url parameter in main class jboss has been moved to params file in commit 26c7345 (PR #26). This causes numerous issues when overriding $product or $version parameters using main class. Like this:

class { 'jboss':
  product => 'wildfly',
  version => '9.0.2.Final',
}

In this example $download_url is being resolved in params.pp file and default values of $product and $version are being used.

There are 2 propositions to fix this:

Move download_url to runtime class and calculate there

• Moving $download_url to jboss::internal::runtime class
• Set parameters from jboss class to jboss::internal::runtime class
• Use parameters from jboss::internal::runtime class instead of params.pp
• Update all references to $jboss::internal::runtime::download_url instead of $jboss::params::download_url

Calculate in params using product and version in runtime class

• Set parameters from jboss class to jboss::internal::runtime class
• Use parameters from jboss::internal::runtime class instead of params.pp

[Cosaquee]

I think that first option is better so i will do that.