Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coil artifacts have same/duplicate manifest package names #384

Closed
ZacSweers opened this issue May 2, 2020 · 3 comments · Fixed by #386
Closed

Coil artifacts have same/duplicate manifest package names #384

ZacSweers opened this issue May 2, 2020 · 3 comments · Fixed by #386
Labels
bug Something isn't working

Comments

@ZacSweers
Copy link
Contributor

Describe the bug
Reported on AGP 4.1 alphas

[io.coil-kt:coil:0.10.1] /Users/zsweers/.gradle/caches/transforms-2/files-2.1/17ebe6f408a1cb3fba8c675f723aa6b6/coil-0.10.1/AndroidManifest.xml Warning:
        Package name 'coil.base' used in: io.coil-kt:coil:0.10.1, io.coil-kt:coil-base:0.10.1.

Expected behavior
They should have different package names

To Reproduce
Build with AGP 4.1

Version
0.10.1

@ZacSweers ZacSweers added the bug Something isn't working label May 2, 2020
@ZacSweers
Copy link
Contributor Author

Can send a PR if you want, but need a new package name. I think single-entry package names (i.e. just coil) still aren't allowed, but maybe coil.core? Or make them all io.coil ± subpackages?

@colinrtwhite
Copy link
Member

colinrtwhite commented May 2, 2020

@ZacSweers Ah thanks for the heads up. What do you think about coil.default and coil.base (same as the Gradle module names)? Definitely open to a PR!

EDIT: Looks like coil.default isn't valid. 🤔 coil.core (for the singleton module) sounds good for the moment to unblock building with AGP 4.1.

@ZacSweers
Copy link
Contributor Author

yeah can't use java keywords in it either :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants