fix VP8X feature flags byte offset #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12..15 "VP8X": 4-bytes tags, describing the extended-VP8 chunk 16..19 Size of the VP8X chunk starting at offset 20 20.... VP8X bytes References: https://developers.google.com/speed/webp/docs/riff_container#extended_file_format
|
Great catch, thanks! For some reason I thought |
colinrtwhite
approved these changes
Apr 12, 2024
colinrtwhite
added a commit
that referenced
this pull request
Apr 30, 2024
* main: Fix deploy docs timeout. Fix disabling polyfills for samples. Update dependency org.jetbrains.compose.compiler:compiler to v1.5.10.2 (#2216) Publish the sample wasmJs app automatically when deploying the docs. (#2213) Update androidx.activity to v1.9.0 (#2209) Update androidx.benchmark to v1.2.4 (#2208) Update dependency org.jetbrains.kotlinx:atomicfu-gradle-plugin to v0.24.0 (#2206) Update dependency org.jetbrains.skiko:skiko to v0.8.1 (#2207) Update dependency androidx.core:core-ktx to v1.13.0 (#2210) Update roborazzi to v1.13.0 (#2212) Upgrade to gradle/actions/wrapper-validation@v3. (#2203) Update gradle/wrapper-validation-action action to v3 (#2202) fix VP8X feature flags byte offset (#2199) Update roborazzi to v1.12.0 (#2201)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VP8X chunk byte format
12..15 "VP8X": 4-bytes tags, describing the extended-VP8 chunk
16..19 Size of the VP8X chunk starting at offset 20
20.... VP8X bytes
References:
https://developers.google.com/speed/webp/docs/riff_container#extended_file_format