Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure View is attached before checking if it is hardware accelerated. #283

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Ensure View is attached before checking if it is hardware accelerated. #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion coil-base/src/main/java/coil/memory/RequestService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ internal class RequestService {
if (!request.allowHardware) return false

// Prevent hardware bitmaps for non-hardware accelerated targets.
if (request.target.run { this is ViewTarget<*> && !view.isHardwareAccelerated }) return false
val target = request.target
if (target is ViewTarget<*> && target.view.run { isAttachedToWindow && !isHardwareAccelerated }) return false

return true
}
Expand Down