Convert SparseIntArraySet.size to a val. #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrtwhite
commented
Apr 30, 2020
| action(elementAt(index)) | ||
| } | ||
| } | ||
|
|
||
| /** Return an iterator over the set's values. */ | ||
| operator fun SparseIntArraySet.iterator(): IntIterator = object : IntIterator() { |
There was a problem hiding this comment.
Added this as SparseIntArray ktx has it.
Jawnnypoo
reviewed
Apr 30, 2020
|
|
||
| /** Adds an element to the set. */ | ||
| /** Returns the number of elements that this set currently stores. */ | ||
| val size: Int @JvmName("size") get() = _size |
There was a problem hiding this comment.
Does JvmName just allow it to be a method for Java callers? Or is it needed otherwise?
There was a problem hiding this comment.
@Jawnnypoo It sets the callable name in Java so Java callers call set.size() instead of set.getSize().
Jawnnypoo
approved these changes
Apr 30, 2020
colinrtwhite
added a commit
that referenced
this pull request
Oct 5, 2022
* Convert SparseIntArraySet.size to a val. * Update binary compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more in line with Kotlin's collections.