-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance reports #107
Closed
Closed
Changes from 5 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
4933e92
Add performance reports
jrbourbeau 178c3ed
Merge branch 'main' of https://github.com/coiled/coiled-runtime into …
jrbourbeau 0bb116f
Upload performance reports
jrbourbeau d4bcace
Merge branch 'main' into performance-reports
ncclementi 6c951da
fix isort lint
ncclementi 92bf35f
Merge branch 'main' of https://github.com/coiled/coiled-runtime into …
jrbourbeau 511b539
Make uploading performance report logic reusable
jrbourbeau 445f629
Make parquet client fixture function scoped
jrbourbeau ef18152
Merge branch 'main' of https://github.com/coiled/coiled-runtime into …
jrbourbeau b389f0e
Fixup
jrbourbeau 30187ec
Undo debugging
jrbourbeau a61ef0a
Merge branch 'main' of https://github.com/coiled/coiled-runtime into …
jrbourbeau 4fa6b33
Add logging
jrbourbeau ee0cd61
Rerun CI
jrbourbeau 1503f23
try to fix conflicts
ncclementi f5dc265
test logging warn
ncclementi 108dc1c
Force fail on purpose for testing
ncclementi 96b4cb7
test logging cli level
ncclementi 3bd9b52
try yield perf report
ncclementi 165a737
test dump works without perf in deadlock test
ncclementi 6118719
Merge branch 'main' into performance-reports
ncclementi afc3347
reduce testing until temp
ncclementi 07311cb
try something different in logging
ncclementi 9a5736d
show status of the situation
ncclementi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use the
coiled
version of performance reports, we should get hosting for freeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I was initially wanting to do, but I believe there's a limit of 5 hosted reports today (xref #107 (comment))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof, good point, I had forgotten about that